Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64: Add byte and short arithmetic opcode evaluators #6780

Merged
merged 1 commit into from
Oct 20, 2022
Merged

AArch64: Add byte and short arithmetic opcode evaluators #6780

merged 1 commit into from
Oct 20, 2022

Conversation

Akira1Saitoh
Copy link
Contributor

Add missing badd/bsub/bmul/sadd/ssub/smul evaluators to aarch64 code generator.

Signed-off-by: Akira Saitoh [email protected]

@Akira1Saitoh Akira1Saitoh marked this pull request as ready for review October 20, 2022 06:20
@knn-k knn-k self-assigned this Oct 20, 2022
@knn-k
Copy link
Contributor

knn-k commented Oct 20, 2022

Please update the copyright year of ArithmeticTest.cpp.

AArch64: Add byte and short arithmetic opcode evaluators
050c27e 
Add missing badd/bsub/bmul/sadd/ssub/smul evaluators to aarch64 code generator.

Signed-off-by: Akira Saitoh <[email protected]>
@Akira1Saitoh
Copy link
Contributor Author

Updated the copyright year.

@knn-k
Copy link
Contributor

knn-k commented Oct 20, 2022

Jenkins build aarch64,amac

@knn-k
Copy link
Contributor

knn-k commented Oct 20, 2022

Jenkins build amac

@knn-k knn-k mentioned this pull request Oct 20, 2022
Closed
@knn-k
Copy link
Contributor

knn-k commented Oct 20, 2022

See #6716 for the failures on macOS. They are not caused by this PR.

[2022-10-20T08:56:59.683Z] The following tests FAILED:
[2022-10-20T08:56:59.683Z] 	 14 - porttest (Failed)
[2022-10-20T08:56:59.683Z] 	 28 - comptest (SIGTRAP)

@knn-k knn-k merged commit 10c21d5 into eclipse:master Oct 20, 2022
@Akira1Saitoh Akira1Saitoh deleted the aarch64ByteShortArithmetic branch October 20, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knn-k knn-k knn-k approved these changes

@Leonardo2718 Leonardo2718 Awaiting requested review from Leonardo2718

@fjeremic fjeremic Awaiting requested review from fjeremic fjeremic is a code owner

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

Assignees

@knn-k knn-k

Labels
arch:aarch64 comp:compiler comp:test comp:tril
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akira1Saitoh @knn-k